Messages in this thread | | | From | Martin Blumenstingl <> | Date | Tue, 14 Dec 2021 19:35:30 +0100 | Subject | Re: [PATCH v1 1/2] mmc: meson-mx-sdhc: Set MANUAL_STOP for multi-block SDIO commands |
| |
Hi Ulf,
On Tue, Dec 14, 2021 at 2:21 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: [...] > > + > > Maybe add a comment to explain a bit about this workaround here? sure, I'll add a paragraph for v2 because this workaround/fix is not obvious
> > + manual_stop = cmd->data->blocks > 1 && > > + (cmd->opcode == SD_IO_RW_DIRECT || > > SD_IO_RW_DIRECT doesn't have cmd->data, so checking for that command > doesn't make sense. This also means that you found a bug in the vendor driver :-) I'll drop SD_IO_RW_DIRECT, do another round of testing and then send an updated version.
Thank you for taking a closer look!
Best regards, Martin
| |