Messages in this thread | | | Subject | Re: [PATCH v17 05/10] x86: kdump: move reserve_crashkernel[_low]() into crash_core.c | From | "Leizhen (ThunderTown)" <> | Date | Tue, 14 Dec 2021 20:38:41 +0800 |
| |
On 2021/12/14 18:45, Baoquan He wrote: >> + /* User specifies base address explicitly. */ > If you plan to repost, please take above sentence off either. Then we > can say this patch is only doing code moving. > >> + unsigned long long start; >> + > OK, I can see that this patch is only moving code, and introducing > CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL to wrap them appropriately, no > extra functionality change added or removed, except of this place. > An alignment checking is added for the user specified base address. > I love this checking. While I have to say it will be more perfect if > it's put in another small patch, that will be look much better from > patch splitting and reviewing point of view.
Good eye. I will put it in a new patch.
> > This whole patch looks great to me, thanks for the effort. > >
| |