Messages in this thread Patch in this message | | | From | Yang Yingliang <> | Subject | [PATCH -next] usb: host: xen-hcd: add missing unlock in error path | Date | Wed, 15 Dec 2021 11:58:05 +0800 |
| |
Add the missing unlock before return from function xenhcd_urb_request_done() and xenhcd_conn_notify() in the error handling case.
Fixes: 494ed3997d75 ("usb: Introduce Xen pvUSB frontend (xen hcd)") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/usb/host/xen-hcd.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c index 7801dde6f5ee..be09fd9bac58 100644 --- a/drivers/usb/host/xen-hcd.c +++ b/drivers/usb/host/xen-hcd.c @@ -942,6 +942,7 @@ static int xenhcd_urb_request_done(struct xenhcd_info *info) rp = info->urb_ring.sring->rsp_prod; if (RING_RESPONSE_PROD_OVERFLOW(&info->urb_ring, rp)) { xenhcd_set_error(info, "Illegal index on urb-ring"); + spin_unlock_irqrestore(&info->lock, flags); return 0; } rmb(); /* ensure we see queued responses up to "rp" */ @@ -997,6 +998,7 @@ static int xenhcd_conn_notify(struct xenhcd_info *info) rp = info->conn_ring.sring->rsp_prod; if (RING_RESPONSE_PROD_OVERFLOW(&info->conn_ring, rp)) { xenhcd_set_error(info, "Illegal index on conn-ring"); + spin_unlock_irqrestore(&info->lock, flags); return 0; } rmb(); /* ensure we see queued responses up to "rp" */ @@ -1010,6 +1012,7 @@ static int xenhcd_conn_notify(struct xenhcd_info *info) if (xenhcd_rhport_connect(info, portnum, speed)) { xenhcd_set_error(info, "Illegal data on conn-ring"); + spin_unlock_irqrestore(&info->lock, flags); return 0; } -- 2.25.1
| |