lkml.org 
[lkml]   [2021]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] blk-mq: make synchronous hw_queue runs RT friendly
On Mon, Dec 13, 2021 at 11:05:29AM -0800, Davidlohr Bueso wrote:
> On Mon, 13 Dec 2021, Christoph Hellwig wrote:
> > But more importantly: why isn't migrate_disable/enable doing the right
> > thing for !PREEMPT_RT to avoid this mess?
>
> Please see Peter's description of the situation in af449901b84.

That explains why migrate_disable is a bad idea in PREEMPT_RT, not why it
can't do something sensible for !PREEMPT_RT…

>
> While I'm not at all a fan of sprinkling migrate_disabling around code,
> I didn't want to add any overhead for the common case. If this, however,
> were not an issue (if most cases are async runs, for example) the ideal
> solution I think would be to just pin current to the hctx->cpumask.

sync running is the performance case.

\
 
 \ /
  Last update: 2021-12-14 09:08    [W:0.050 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site