lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 152/171] iio: dln2: Check return value of devm_iio_trigger_register()
    Date
    From: Lars-Peter Clausen <lars@metafoo.de>

    commit 90751fb9f224e0e1555b49a8aa9e68f6537e4cec upstream.

    Registering a trigger can fail and the return value of
    devm_iio_trigger_register() must be checked. Otherwise undefined behavior
    can occur when the trigger is used.

    Fixes: 7c0299e879dd ("iio: adc: Add support for DLN2 ADC")
    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    Link: https://lore.kernel.org/r/20211101133043.6974-1-lars@metafoo.de
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/adc/dln2-adc.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/iio/adc/dln2-adc.c
    +++ b/drivers/iio/adc/dln2-adc.c
    @@ -655,7 +655,11 @@ static int dln2_adc_probe(struct platfor
    return -ENOMEM;
    }
    iio_trigger_set_drvdata(dln2->trig, dln2);
    - devm_iio_trigger_register(dev, dln2->trig);
    + ret = devm_iio_trigger_register(dev, dln2->trig);
    + if (ret) {
    + dev_err(dev, "failed to register trigger: %d\n", ret);
    + return ret;
    + }
    iio_trigger_set_immutable(indio_dev, dln2->trig);

    ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL,

    \
     
     \ /
      Last update: 2021-12-13 11:29    [W:3.471 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site