lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 101/132] USB: gadget: zero allocate endpoint 0 buffers
    Date
    From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    commit 86ebbc11bb3f60908a51f3e41a17e3f477c2eaa3 upstream.

    Under some conditions, USB gadget devices can show allocated buffer
    contents to a host. Fix this up by zero-allocating them so that any
    extra data will all just be zeros.

    Reported-by: Szymon Heidrich <szymon.heidrich@gmail.com>
    Tested-by: Szymon Heidrich <szymon.heidrich@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/composite.c | 2 +-
    drivers/usb/gadget/legacy/dbgp.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/usb/gadget/composite.c
    +++ b/drivers/usb/gadget/composite.c
    @@ -2173,7 +2173,7 @@ int composite_dev_prepare(struct usb_com
    if (!cdev->req)
    return -ENOMEM;

    - cdev->req->buf = kmalloc(USB_COMP_EP0_BUFSIZ, GFP_KERNEL);
    + cdev->req->buf = kzalloc(USB_COMP_EP0_BUFSIZ, GFP_KERNEL);
    if (!cdev->req->buf)
    goto fail;

    --- a/drivers/usb/gadget/legacy/dbgp.c
    +++ b/drivers/usb/gadget/legacy/dbgp.c
    @@ -137,7 +137,7 @@ static int dbgp_enable_ep_req(struct usb
    goto fail_1;
    }

    - req->buf = kmalloc(DBGP_REQ_LEN, GFP_KERNEL);
    + req->buf = kzalloc(DBGP_REQ_LEN, GFP_KERNEL);
    if (!req->buf) {
    err = -ENOMEM;
    stp = 2;

    \
     
     \ /
      Last update: 2021-12-13 11:15    [W:4.098 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site