lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 106/132] iio: gyro: adxrs290: fix data signedness
    Date
    From: Kister Genesis Jimenez <kister.jimenez@analog.com>

    commit fde272e78e004a45c7e4976876277d7e6a5a0ede upstream.

    Properly sign-extend the rate and temperature data.

    Fixes: 2c8920fff1457 ("iio: gyro: Add driver support for ADXRS290")
    Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>
    Signed-off-by: Nuno Sá <nuno.sa@analog.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Link: https://lore.kernel.org/r/20211115104147.18669-1-nuno.sa@analog.com
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/gyro/adxrs290.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/iio/gyro/adxrs290.c
    +++ b/drivers/iio/gyro/adxrs290.c
    @@ -7,6 +7,7 @@
    */

    #include <linux/bitfield.h>
    +#include <linux/bitops.h>
    #include <linux/delay.h>
    #include <linux/device.h>
    #include <linux/kernel.h>
    @@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct
    goto err_unlock;
    }

    - *val = temp;
    + *val = sign_extend32(temp, 15);

    err_unlock:
    mutex_unlock(&st->lock);
    @@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct
    }

    /* extract lower 12 bits temperature reading */
    - *val = temp & 0x0FFF;
    + *val = sign_extend32(temp, 11);

    err_unlock:
    mutex_unlock(&st->lock);

    \
     
     \ /
      Last update: 2021-12-13 11:15    [W:4.088 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site