lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 081/132] RDMA/hns: Do not halt commands during reset until later
    Date
    From: Yangyang Li <liyangyang20@huawei.com>

    commit 52414e27d6b568120b087d1fbafbb4482b0ccaab upstream.

    is_reset is used to indicate whether the hardware starts to reset. When
    hns_roce_hw_v2_reset_notify_down() is called, the hardware has not yet
    started to reset. If is_reset is set at this time, all mailbox operations
    of resource destroy actions will be intercepted by driver. When the driver
    cleans up resources, but the hardware is still accessed, the following
    errors will appear:

    arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000350100000010
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x000002088000003f
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x00000000a50e0800
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000000000000000
    arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000350100000010
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x000002088000043e
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x00000000a50a0800
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000000000000000
    arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000350100000010
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000020880000436
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x00000000a50a0880
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000000000000000
    arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000350100000010
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x000002088000043a
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x00000000a50e0840
    hns3 0000:35:00.0: INT status: CMDQ(0x0) HW errors(0x0) other(0x0)
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000000000000000
    hns3 0000:35:00.0: received unknown or unhandled event of vector0
    arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
    arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000350100000010
    {34}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 7

    is_reset will be set correctly in check_aedev_reset_status(), so the
    setting in hns_roce_hw_v2_reset_notify_down() should be deleted.

    Fixes: 726be12f5ca0 ("RDMA/hns: Set reset flag when hw resetting")
    Link: https://lore.kernel.org/r/20211123084809.37318-1-liangwenpeng@huawei.com
    Signed-off-by: Yangyang Li <liyangyang20@huawei.com>
    Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
    @@ -6342,10 +6342,8 @@ static int hns_roce_hw_v2_reset_notify_d
    if (!hr_dev)
    return 0;

    - hr_dev->is_reset = true;
    hr_dev->active = false;
    hr_dev->dis_db = true;
    -
    hr_dev->state = HNS_ROCE_DEVICE_STATE_RST_DOWN;

    return 0;

    \
     
     \ /
      Last update: 2021-12-13 11:11    [W:2.114 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site