lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 009/171] HID: bigbenff: prevent null pointer dereference
    Date
    From: Benjamin Tissoires <benjamin.tissoires@redhat.com>

    commit 918aa1ef104d286d16b9e7ef139a463ac7a296f0 upstream.

    When emulating the device through uhid, there is a chance we don't have
    output reports and so report_field is null.

    Cc: stable@vger.kernel.org
    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20211202095334.14399-3-benjamin.tissoires@redhat.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/hid/hid-bigbenff.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hid/hid-bigbenff.c
    +++ b/drivers/hid/hid-bigbenff.c
    @@ -191,7 +191,7 @@ static void bigben_worker(struct work_st
    struct bigben_device, worker);
    struct hid_field *report_field = bigben->report->field[0];

    - if (bigben->removed)
    + if (bigben->removed || !report_field)
    return;

    if (bigben->work_led) {

    \
     
     \ /
      Last update: 2021-12-13 11:05    [W:4.038 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site