Messages in this thread Patch in this message | | | From | Qing Wang <> | Subject | [PATCH] net: phy: add missing of_node_put before return | Date | Mon, 13 Dec 2021 01:44:49 -0800 |
| |
From: Wang Qing <wangqing@vivo.com>
Fix following coccicheck warning: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return.
Early exits from for_each_available_child_of_node should decrement the node reference counter.
Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/net/phy/mdio_bus.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 9b6f2df..3c5e8937 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -462,6 +462,7 @@ static void of_mdiobus_link_mdiodev(struct mii_bus *bus, if (addr == mdiodev->addr) { device_set_node(dev, of_fwnode_handle(child)); + of_node_put(child); return; } } -- 2.7.4
| |