Messages in this thread Patch in this message | | | From | Qing Wang <> | Subject | [PATCH] mailbox: zynq: add missing of_node_put before return | Date | Mon, 13 Dec 2021 01:44:20 -0800 |
| |
From: Wang Qing <wangqing@vivo.com>
Fix following coccicheck warning: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return.
Early exits from for_each_available_child_of_node should decrement the node reference counter.
Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/mailbox/zynqmp-ipi-mailbox.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index f44079d..31a0fa9 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -655,6 +655,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev) mbox->pdata = pdata; ret = zynqmp_ipi_mbox_probe(mbox, nc); if (ret) { + of_node_put(nc); dev_err(dev, "failed to probe subdev.\n"); ret = -EINVAL; goto free_mbox_dev; -- 2.7.4
| |