lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 09/74] can: sja1000: fix use after free in ems_pcmcia_add_card()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 3ec6ca6b1a8e64389f0212b5a1b0f6fed1909e45 upstream.

    If the last channel is not available then "dev" is freed. Fortunately,
    we can just use "pdev->irq" instead.

    Also we should check if at least one channel was set up.

    Fixes: fd734c6f25ae ("can/sja1000: add driver for EMS PCMCIA card")
    Link: https://lore.kernel.org/all/20211124145041.GB13656@kili
    Cc: stable@vger.kernel.org
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
    Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/sja1000/ems_pcmcia.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/drivers/net/can/sja1000/ems_pcmcia.c
    +++ b/drivers/net/can/sja1000/ems_pcmcia.c
    @@ -243,7 +243,12 @@ static int ems_pcmcia_add_card(struct pc
    free_sja1000dev(dev);
    }

    - err = request_irq(dev->irq, &ems_pcmcia_interrupt, IRQF_SHARED,
    + if (!card->channels) {
    + err = -ENODEV;
    + goto failure_cleanup;
    + }
    +
    + err = request_irq(pdev->irq, &ems_pcmcia_interrupt, IRQF_SHARED,
    DRV_NAME, card);
    if (!err)
    return 0;

    \
     
     \ /
      Last update: 2021-12-13 10:42    [W:5.509 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site