lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/2] pmic-cpcap: add motorola,droid3 compatible
* Merlijn Wajer <merlijn@wizzup.org> [211212 23:00]:
> The Droid 3 and the Bionic appear to share the same hardware, so add
> the compatible for the Droid 3 as well.
>
> Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
> ---
> arch/arm/mach-omap2/pmic-cpcap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/pmic-cpcap.c b/arch/arm/mach-omap2/pmic-cpcap.c
> index 668dc84fd31e..b9188dde13b9 100644
> --- a/arch/arm/mach-omap2/pmic-cpcap.c
> +++ b/arch/arm/mach-omap2/pmic-cpcap.c
> @@ -245,7 +245,8 @@ int __init omap4_cpcap_init(void)
> voltdm = voltdm_lookup("mpu");
> omap_voltage_register_pmic(voltdm, &omap443x_max8952_mpu);
>
> - if (of_machine_is_compatible("motorola,droid-bionic")) {
> + if (of_machine_is_compatible("motorola,droid-bionic") ||
> + of_machine_is_compatible("motorola,droid3")) {
> voltdm = voltdm_lookup("core");
> omap_voltage_register_pmic(voltdm, &omap_cpcap_core);
>

Looks OK to me, however we should also add all the mapphones to the
Documentation/devicetree/bindings/arm/omap/omap.txt so we can avoid
dtb check warnings. Care to also do a patch for that? Looks like the
others are missing too.

Regards,

Tony


\
 
 \ /
  Last update: 2021-12-13 06:59    [W:0.061 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site