lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 37/42] iio: itg3200: Call iio_trigger_notify_done() on error
    Date
    From: Lars-Peter Clausen <lars@metafoo.de>

    commit 67fe29583e72b2103abb661bb58036e3c1f00277 upstream.

    IIO trigger handlers must call iio_trigger_notify_done() when done. This
    must be done even when an error occurred. Otherwise the trigger will be
    seen as busy indefinitely and the trigger handler will never be called
    again.

    The itg3200 driver neglects to call iio_trigger_notify_done() when there is
    an error reading the gyro data. Fix this by making sure that
    iio_trigger_notify_done() is included in the error exit path.

    Fixes: 9dbf091da080 ("iio: gyro: Add itg3200")
    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    Link: https://lore.kernel.org/r/20211101144055.13858-1-lars@metafoo.de
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/gyro/itg3200_buffer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iio/gyro/itg3200_buffer.c
    +++ b/drivers/iio/gyro/itg3200_buffer.c
    @@ -64,9 +64,9 @@ static irqreturn_t itg3200_trigger_handl

    iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);

    +error_ret:
    iio_trigger_notify_done(indio_dev->trig);

    -error_ret:
    return IRQ_HANDLED;
    }


    \
     
     \ /
      Last update: 2021-12-13 10:37    [W:4.226 / U:0.788 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site