lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 11/23] nvme-pci: convert to using dma_map_sgtable()

On 2021-12-13 3:21 p.m., Chaitanya Kulkarni wrote:
>
>> static blk_status_t nvme_pci_setup_sgls(struct nvme_dev *dev,
>> - struct request *req, struct nvme_rw_command *cmd, int entries)
>> + struct request *req, struct nvme_rw_command *cmd)
>> {
>> struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
>> struct dma_pool *pool;
>> struct nvme_sgl_desc *sg_list;
>> - struct scatterlist *sg = iod->sg;
>> + struct scatterlist *sg = iod->sgt.sgl;
>> + int entries = iod->sgt.nents;
>
> I don't see use of newly added entries variable anywhere in
> nvme_pci_setup_sgls(), what am I missing ?

'entries' is being moved out from the argument list of
nvme_pci_setup_sgls(), so there are already uses in the function that
don't show in the diff.

> Also, type of entries variable should be unsigned int to match
> the iod->sgt.nents.

Sure, I will fix that in the next version.

Thanks for the reviews!

Logan

\
 
 \ /
  Last update: 2021-12-13 23:29    [W:0.052 / U:8.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site