[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 03/23] PCI/P2PDMA: Attempt to set map_type if it has not been set
On 11/17/21 1:53 PM, Logan Gunthorpe wrote:
> Attempt to find the mapping type for P2PDMA pages on the first
> DMA map attempt if it has not been done ahead of time.
> Previously, the mapping type was expected to be calculated ahead of
> time, but if pages are to come from userspace then there's no
> way to ensure the path was checked ahead of time.
> This change will calculate the mapping type if it hasn't pre-calculated
> so it is no longer invalid to call pci_p2pdma_map_sg() before the mapping
> type is calculated, so drop the WARN_ON when that is he case.
> Signed-off-by: Logan Gunthorpe <>
> Acked-by: Bjorn Helgaas <>
> ---

Perhaps a comment would be nice in the default case in
pci_p2pdma_map_sg_attrs() where you have removed the WARN_ON_ONCE().

Either way, looks good.

Reviewed-by: Chaitanya Kulkarni <>

 \ /
  Last update: 2021-12-13 23:01    [W:0.156 / U:12.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site