lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v20] tty: Fix the keyboard led light display problem
On Mon, Dec 13, 2021 at 11:41:09AM -0800, Dmitry Torokhov wrote:
> On Mon, Dec 13, 2021 at 04:41:24AM -0800, Joe Perches wrote:
> > On Mon, 2021-12-13 at 14:15 +0200, Andy Shevchenko wrote:
> > > On Mon, Dec 13, 2021 at 02:12:44PM +0800, lianzhi chang wrote:
> >
> > > > + struct kbd_struct *kb = &kbd_table[console];
> > > > + int ret = 0;
> > > > + unsigned long flags;
> > >
> > > Slightly better to read:
> > >
> > > struct kbd_struct *kb = &kbd_table[console];
> > > unsigned long flags;
> > > int ret = 0;
> >
> > I don't think so. Why do you?
>
> I wonder why we comment on cosmetics of a patch

> (and have the submitter rush to fix that)

Not sure where you got this from...

> without considering if the proposed solution makes
> sense in the first place?

...but answering your question it's quite natural in open source mailing list
that people give a comment regarding their area of expertise. One does for
style another for the whole solution. I don't think anything is wrong with this
approach, do you?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-12-13 21:08    [W:0.072 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site