Messages in this thread |  | | Date | Tue, 14 Dec 2021 03:47:22 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v2 2/4] coresight: etm4x: Don't use virtual contextID for non-root PID namespace |
| |
Hi Leo,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Leo-Yan/coresight-etm-Correct-PID-tracing-for-non-root-namespace/20211213-201632 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2585cf9dfaaddf00b069673f27bb3f8530e2039c config: arm64-randconfig-r034-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140333.58pdbVRp-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/3b7eceb25155c98432dea4821c4fc571b44d72e3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Leo-Yan/coresight-etm-Correct-PID-tracing-for-non-root-namespace/20211213-201632 git checkout 3b7eceb25155c98432dea4821c4fc571b44d72e3 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/hwtracing/coresight/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2118:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration] if (!task_is_in_init_pid_ns(current)) ^ drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2139:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration] if (!task_is_in_init_pid_ns(current)) ^ drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2169:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration] if (!task_is_in_init_pid_ns(current)) ^ drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2193:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration] if (!task_is_in_init_pid_ns(current)) ^ 4 errors generated.
vim +/task_is_in_init_pid_ns +2118 drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
2105 2106 static ssize_t vmid_val_show(struct device *dev, 2107 struct device_attribute *attr, 2108 char *buf) 2109 { 2110 unsigned long val; 2111 struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); 2112 struct etmv4_config *config = &drvdata->config; 2113 2114 /* 2115 * Don't use virtual contextID tracing if coming from a PID namespace. 2116 * See comment in ctxid_pid_store(). 2117 */ > 2118 if (!task_is_in_init_pid_ns(current)) 2119 return -EINVAL; 2120 2121 spin_lock(&drvdata->spinlock); 2122 val = (unsigned long)config->vmid_val[config->vmid_idx]; 2123 spin_unlock(&drvdata->spinlock); 2124 return scnprintf(buf, PAGE_SIZE, "%#lx\n", val); 2125 } 2126
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
|  |