lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.
On Sat, Dec 11, 2021 at 1:35 PM 呂芳騰 <wellslutw@gmail.com> wrote:
>
> Hi Rob,
>
> Thank you very much for your review.
> Please see my replies below:
>
> > Add bindings documentation for Sunplus SP7021.
> >
> [...]
> > > +
> > > + interrupts:
> > > + description: |
> > > + Contains number and type of interrupt. Number should be 66.
> >
> > Drop. That's every 'interrupts' and the exact number is outside the
> > scope of the binding.
>
> Yes, I'll drop the descriptions next patch.
> interrupts property will be:
>
> interrupts:
> maxItems: 1
>
>
> [...]
> > > +
> > > + mdio:
> >
> > Just need:
> >
> > $ref: mdio.yaml#
> > unevaluatedProperties: false
> >
> > and drop the rest.
>
> Yes, I'll modify mdio node next patch.
> mdio node will be:
>
> mdio:
> $ref: mdio.yaml#
> unevaluatedProperties: false
>
>
> > > + type: object
> > > + description: external MDIO Bus
> > > +
> > > + properties:
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 0
> > > +
> > > + patternProperties:
> > > + "^ethernet-phy@[0-9a-f]+$":
> > > + type: object
> > > + description: external PHY node
> > > +
> > > + properties:
> > > + reg:
> > > + minimum: 0
> > > + maximum: 30
>
> Can I limit value of 'reg' to no more than 30?

Isn't that the limit for any MDIO bus? I guess normally 31 is also
valid? I'm not really sure it is worth adding just for that 1 possible
value. Within the range of valid addresses, we can't ever validate
that a DT has the correct address.

Rob

\
 
 \ /
  Last update: 2021-12-13 20:31    [W:0.086 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site