Messages in this thread | | | Subject | Re: [PATCH 16/25] x86/sgx: Support modifying SGX page type | From | Dave Hansen <> | Date | Mon, 13 Dec 2021 09:43:38 -0800 |
| |
On 12/11/21 12:02 AM, Jarkko Sakkinen wrote: > On Mon, 2021-12-06 at 13:48 -0800, Reinette Chatre wrote: >>> I'd suggest to change this as SGX_IOC_ENCLAVE_MODIFY_TYPE. >> How about SGX_IOC_ENCLAVE_MOD_TYPE to be consistent with your earlier >> suggestion of SGX_IOC_ENCLAVE_MOD_PROTECTIONS ? > I think it would be best to introduce only one new ioctl that would > be capable of doing either operation (and use secinfo as a vessel > for additional data).
Why?
I don't think we should try to multiplex within an ioctl(). Just create a second ioctl().
| |