Messages in this thread | | | Date | Mon, 13 Dec 2021 11:52:06 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing: check the return value of kstrdup() |
| |
On Mon, 13 Dec 2021 15:59:04 +0800 Xiaoke Wang <xkernel.wang@foxmail.com> wrote:
> Note: Compare with the last email, this one is using my full name. > And I am sorry that yesterday I did not notice the bugs in trace_boot.c had been > already patched. > kstrdup() returns NULL when some internal memory errors happen, it is > better to check the return value of it.
Can you please resend this as a normal patch, and not a reply to this email thread.
Thank you,
-- Steve
> > Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> > --- > kernel/trace/trace_uprobe.c | 5 +++++ > 1 files changed, 5 insertions(+) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 225ce56..173ff0f 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs, > tu->path = path; > tu->ref_ctr_offset = ref_ctr_offset; > tu->filename = kstrdup(name, GFP_KERNEL); > + if (!tu->filename) { > + ret = -ENOMEM; > + goto error; > + } > + > init_trace_event_call(tu); > > ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
| |