lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 01/10] exit/s390: Remove dead reference to do_exit from copy_thread
    Heiko Carstens <hca@linux.ibm.com> writes:

    > On Wed, Dec 08, 2021 at 02:25:23PM -0600, Eric W. Biederman wrote:
    >> My s390 assembly is not particularly good so I have read the history
    >> of the reference to do_exit copy_thread and have been able to
    >> verify that do_exit is not used.
    >>
    >> The general argument is that s390 has been changed to use the generic
    >> kernel_thread and kernel_execve and the generic versions do not call
    >> do_exit. So it is strange to see a do_exit reference sitting there.
    >>
    >> The history of the do_exit reference in s390's version of copy_thread
    >> seems conclusive that the do_exit reference is something that lingers
    >> and should have been removed several years ago.
    > ...
    >> Remove this dead reference to do_exit to make it clear that s390 is
    >> not doing anything with do_exit in copy_thread.
    >>
    >> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    >> ---
    >> arch/s390/kernel/process.c | 1 -
    >> 1 file changed, 1 deletion(-)
    >
    > Applied to s390 tree. Just in case you want to apply this to your tree too:
    > Acked-by: Heiko Carstens <hca@linux.ibm.com>

    Thank you for looking at this and confirming I had read that the code
    properly and that the do_exit reference was no longer used.

    I will probably take this through my tree as well just so I don't have
    that trailing do_exit reference.

    At this point I will give things a bit more for people to review or say
    something about the other changes and if there is no negative feedback
    I think I will just apply the lot.

    Eric

    \
     
     \ /
      Last update: 2021-12-13 15:52    [W:4.301 / U:0.888 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site