lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH MANUALSEL 5.10 2/4] KVM: VMX: clear vmx_x86_ops.sync_pir_to_irr if APICv is disabled
From
On 12/13/21 15:20, Sasha Levin wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> [ Upstream commit e90e51d5f01d2baae5dcce280866bbb96816e978 ]
>
> There is nothing to synchronize if APICv is disabled, since neither
> other vCPUs nor assigned devices can set PIR.ON.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> arch/x86/kvm/vmx/vmx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 5b7664d51dc2b..dff8ab5a53280 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7814,10 +7814,10 @@ static __init int hardware_setup(void)
> ple_window_shrink = 0;
> }
>
> - if (!cpu_has_vmx_apicv()) {
> + if (!cpu_has_vmx_apicv())
> enable_apicv = 0;
> + if (!enable_apicv)
> vmx_x86_ops.sync_pir_to_irr = NULL;
> - }
>
> if (cpu_has_vmx_tsc_scaling()) {
> kvm_has_tsc_control = true;
>

NACK - the patch is only okay to backport for 5.15

Paolo

\
 
 \ /
  Last update: 2021-12-13 15:29    [W:0.922 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site