Messages in this thread | | | Date | Mon, 13 Dec 2021 15:28:39 +0100 | Subject | Re: [PATCH MANUALSEL 5.15 9/9] x86/kvm: remove unused ack_notifier callbacks | From | Paolo Bonzini <> |
| |
On 12/13/21 15:19, Sasha Levin wrote: > From: Juergen Gross <jgross@suse.com> > > [ Upstream commit 9dba4d24cbb5524dd39ab1e08886373b17f07ff2 ] > > Commit f52447261bc8c2 ("KVM: irq ack notification") introduced an > ack_notifier() callback in struct kvm_pic and in struct kvm_ioapic > without using them anywhere. Remove those callbacks again. > > Signed-off-by: Juergen Gross <jgross@suse.com> > Message-Id: <20211117071617.19504-1-jgross@suse.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > arch/x86/kvm/ioapic.h | 1 - > arch/x86/kvm/irq.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h > index 27e61ff3ac3e8..f1b2b2a6ff4db 100644 > --- a/arch/x86/kvm/ioapic.h > +++ b/arch/x86/kvm/ioapic.h > @@ -81,7 +81,6 @@ struct kvm_ioapic { > unsigned long irq_states[IOAPIC_NUM_PINS]; > struct kvm_io_device dev; > struct kvm *kvm; > - void (*ack_notifier)(void *opaque, int irq); > spinlock_t lock; > struct rtc_status rtc_status; > struct delayed_work eoi_inject; > diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h > index 650642b18d151..c2d7cfe82d004 100644 > --- a/arch/x86/kvm/irq.h > +++ b/arch/x86/kvm/irq.h > @@ -56,7 +56,6 @@ struct kvm_pic { > struct kvm_io_device dev_master; > struct kvm_io_device dev_slave; > struct kvm_io_device dev_elcr; > - void (*ack_notifier)(void *opaque, int irq); > unsigned long irq_states[PIC_NUM_PINS]; > }; > >
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Let's save 24 bytes per VM. :)
Paolo
| |