lkml.org 
[lkml]   [2021]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
On Sat, Dec 11, 2021 at 01:13:52PM +0300, Sergey Shtylyov wrote:
> On 10.12.2021 22:35, Sergei Shtylyov wrote:

...

> Also, your commit log is wrong in the description of how to handle the result:
>
> <<
> Now:
> ret = platform_get_irq_optional(...);
> if (ret != -ENXIO)
> return ret; // respect deferred probe
> if (ret > 0)
> ...we get an IRQ...
> >>
>
> The (ret != -ENXIO) check also succeeds on the (positive) IRQ #s, so the
> following code becomes unreachable. :-/

Indeed, thanks!

Should be
if (ret < 0 && ret != -ENXIO)

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-12-13 12:27    [W:0.099 / U:2.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site