Messages in this thread | | | Date | Mon, 13 Dec 2021 13:26:33 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved |
| |
On Sat, Dec 11, 2021 at 01:13:52PM +0300, Sergey Shtylyov wrote: > On 10.12.2021 22:35, Sergei Shtylyov wrote:
...
> Also, your commit log is wrong in the description of how to handle the result: > > << > Now: > ret = platform_get_irq_optional(...); > if (ret != -ENXIO) > return ret; // respect deferred probe > if (ret > 0) > ...we get an IRQ... > >> > > The (ret != -ENXIO) check also succeeds on the (positive) IRQ #s, so the > following code becomes unreachable. :-/
Indeed, thanks!
Should be if (ret < 0 && ret != -ENXIO)
-- With Best Regards, Andy Shevchenko
| |