Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 13 Dec 2021 00:59:18 +0100 | Subject | Re: [PATCH 2/2] leds: lp55xx: initialise output direction from dts |
| |
On Sun, Dec 12, 2021 at 11:34 PM Merlijn Wajer <merlijn@wizzup.org> wrote:
> Commit a5d3d1adc95f ("leds: lp55xx: Initialize enable GPIO direction to > output") attempts to fix this, but the fix did not work since at least > for the Nokia N900 the value needs to be set to HIGH, per the device > tree. So rather than hardcoding the value to a potentially invalid value > for some devices, let's set direction in lp55xx_init_device. > > Fixes: a5d3d1adc95f ("leds: lp55xx: Initialize enable GPIO direction to output") > Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx") > Fixes: ac219bf3c9bd ("leds: lp55xx: Convert to use GPIO descriptors") > Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks for fixing my mistakes!
Yours, Linus Walleij
| |