Messages in this thread | | | Subject | Re: [PATCH] ALSA: jack: Check the return value of kstrdup() | From | Joe Perches <> | Date | Sat, 11 Dec 2021 21:44:33 -0800 |
| |
On Sun, 2021-12-12 at 01:13 +0800, xkernel wrote: > kstrdup() can return NULL, it is better to check the return value of it. [] > diff --git a/sound/core/jack.c b/sound/core/jack.c [] > @@ -509,6 +509,8 @@ int snd_jack_new(struct snd_card *card, const char *id, int type, > return -ENOMEM; > > jack->id = kstrdup(id, GFP_KERNEL); > + if (jack->id == NULL) > + return -ENOMEM;
jack should be freed too.
if (!jack->id) { kfree(jack); return -ENOMEM; }
> > /* don't creat input device for phantom jack */ > if (!phantom_jack) {
| |