lkml.org 
[lkml]   [2021]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ALSA: jack: Check the return value of kstrdup()
From
Date
On Sun, 2021-12-12 at 01:13 +0800, xkernel wrote:
> kstrdup() can return NULL, it is better to check the return value of it.
[]
> diff --git a/sound/core/jack.c b/sound/core/jack.c
[]
> @@ -509,6 +509,8 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
> return -ENOMEM;
>
> jack->id = kstrdup(id, GFP_KERNEL);
> + if (jack->id == NULL)
> + return -ENOMEM;

jack should be freed too.

if (!jack->id) {
kfree(jack);
return -ENOMEM;
}

>
> /* don't creat input device for phantom jack */
> if (!phantom_jack) {


\
 
 \ /
  Last update: 2021-12-12 06:45    [W:2.700 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site