lkml.org 
[lkml]   [2021]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/6] dt-bindings: interrupt-controller: apple,aic: Add apple,aic2 support
Date
On 10/12/2021 02.28, Rob Herring wrote:
> On Thu, Dec 09, 2021 at 01:32:44PM +0900, Hector Martin wrote:
<snip>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - apple,aic2
>> + then:
>> + required:
>> + - apple,event-reg
>
> Is this property valid for aic1? If not, you need:
>
> else:
> not:
> required:
> - apple,event-reg
>

Thanks, I wasn't sure how to do this. Took me a second to realize how
the logic works here, heh.

>
> I tend to think you should just make this a separate document. There's
> not a whole lot of sharing (compared to any other interrupt controller).

Good point. I just kind of defaulted to this way because the driver is
the same (and does share a bunch), but indeed the binding doesn't really
reflect any of that. I'll split it off into another document for v2.
Might as well make the 4-argument interrupt form mandatory then (we use
it for all DTs, even the current 1-die machines, on AICv2 SoCs; the
driver can handle both but we might as well be stricter with the binding).

--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub

\
 
 \ /
  Last update: 2021-12-11 13:29    [W:0.123 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site