lkml.org 
[lkml]   [2021]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] perf tools: Fix NULL vs IS_ERR_OR_NULL() checking
Em Sat, Dec 11, 2021 at 05:38:53AM +0000, Miaoqian Lin escreveu:
> The function trace_event__tp_format_id may return ERR_PTR(-ENOMEM).
> Use IS_ERR_OR_NULL to check tp_format.

Thanks, applied.

- Arnaldo


> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> tools/perf/util/python.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
> index 563a9ba8954f..7f782a31bda3 100644
> --- a/tools/perf/util/python.c
> +++ b/tools/perf/util/python.c
> @@ -461,7 +461,7 @@ get_tracepoint_field(struct pyrf_event *pevent, PyObject *attr_name)
> struct tep_event *tp_format;
>
> tp_format = trace_event__tp_format_id(evsel->core.attr.config);
> - if (!tp_format)
> + if (IS_ERR_OR_NULL(tp_format))
> return NULL;
>
> evsel->tp_format = tp_format;
> --
> 2.17.1

--

- Arnaldo

\
 
 \ /
  Last update: 2021-12-11 12:27    [W:0.027 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site