lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 1/3] dt-binding: mt8183: add Mediatek MDP3 dt-bindings
On Thu, Dec 02, 2021 at 02:27:31PM +0800, Moudy Ho wrote:
> This patch adds DT binding document for Media Data Path 3 (MDP3)
> a unit in multimedia system used for scaling and color format convert.
>
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> ---
> .../bindings/media/mediatek,mdp3-rsz.yaml | 65 ++++++
> .../bindings/media/mediatek,mdp3-wrot.yaml | 67 ++++++
> .../bindings/soc/mediatek/mediatek,ccorr.yaml | 57 +++++
> .../bindings/soc/mediatek/mediatek,rdma.yaml | 216 ++++++++++++++++++
> .../bindings/soc/mediatek/mediatek,wdma.yaml | 68 ++++++
> 5 files changed, 473 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,rdma.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml

I'm not a fan of bindings/soc/ either. Put everything in
bindings/media/. What's the difference between these blocks here and
the version used for display? If they are the same h/w, then the binding
needs to be the same. How they get used is the kernel's problem.

It looks like the display ccorr, rdma, and wdma aren't documented. Fix
that before you add new stuff.


> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> new file mode 100644
> index 000000000000..d7f104a0f165
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mdp3-rsz.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Resizer
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@gmail.com>
> +
> +description: |
> + One of Media Data Path 3 (MDP3) components used to do frame resizing.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - mediatek,mt8183-mdp3-rsz
> +
> + mediatek,mdp3-id:
> + description: There may be multiple components with the same function but
> + different addresses in MDP3. The MDP3 driver can select one or zero of
> + them and connect other components in series according to the current
> + application to form one or more data paths. This property indicate the
> + selection order of the same components.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 1, 2, 3]

Again, an index nor an alias is the right approach for this. Use DT
graph like others do. 'It's too complicated' is not a reason unless you
show how and why it won't work.

Rob

\
 
 \ /
  Last update: 2021-12-10 19:17    [W:0.080 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site