| Date | Fri, 10 Dec 2021 18:04:03 +0000 | From | Catalin Marinas <> | Subject | Re: [PATCH v2 32/34] arm64: select KASAN_VMALLOC for SW/HW_TAGS modes |
| |
On Mon, Dec 06, 2021 at 10:44:09PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov <andreyknvl@google.com> > > Generic KASAN already selects KASAN_VMALLOC to allow VMAP_STACK to be > selected unconditionally, see commit acc3042d62cb9 ("arm64: Kconfig: > select KASAN_VMALLOC if KANSAN_GENERIC is enabled"). > > The same change is needed for SW_TAGS KASAN. > > HW_TAGS KASAN does not require enabling KASAN_VMALLOC for VMAP_STACK, > they already work together as is. Still, selecting KASAN_VMALLOC still > makes sense to make vmalloc() always protected. In case any bugs in > KASAN's vmalloc() support are discovered, the command line kasan.vmalloc > flag can be used to disable vmalloc() checking. > > This patch selects KASAN_VMALLOC for all KASAN modes for arm64. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
I also had a look at the rest of the patches and they look fine to me (even the init_tags comment, feel free to ignore it). I'll poke Vincenzo next week to look at the patches with his co-developed-by tag.
-- Catalin
|