lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ASoC: add ES8156 codec driver
Hi Shumin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Shumin-Chen/This-patches-provide-ASoc-codec-support-for-ES8156/20211210-231527
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-buildonly-randconfig-r003-20211210 (https://download.01.org/0day-ci/archive/20211211/202112110101.i4FDNZ9c-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/4ea33be548d361d7097073473fb018e016091622
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shumin-Chen/This-patches-provide-ASoc-codec-support-for-ES8156/20211210-231527
git checkout 4ea33be548d361d7097073473fb018e016091622
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/codecs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/es8156.c:402:5: warning: no previous prototype for 'es8156_headset_detect' [-Wmissing-prototypes]
402 | int es8156_headset_detect(int jack_insert)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/es8156.c:421:13: warning: 'hp_work' defined but not used [-Wunused-function]
421 | static void hp_work(struct work_struct *work)
| ^~~~~~~
sound/soc/codecs/es8156.c:386:20: warning: 'es8156_irq_handler' defined but not used [-Wunused-function]
386 | static irqreturn_t es8156_irq_handler(int irq, void *data)
| ^~~~~~~~~~~~~~~~~~


vim +/es8156_headset_detect +402 sound/soc/codecs/es8156.c

395
396 /*
397 * Call from rk_headset_irq_hook_adc.c
398 *
399 * Enable micbias for HOOK detection and disable external Amplifier
400 * when jack insertion.
401 */
> 402 int es8156_headset_detect(int jack_insert)
403 {
404 struct es8156_priv *es8156;
405
406 if (!es8156_codec)
407 return -1;
408
409 es8156 = snd_soc_component_get_drvdata(es8156_codec);
410
411 es8156->hp_inserted = jack_insert;
412
413 /* enable micbias and disable PA */
414 if (jack_insert)
415 es8156_enable_spk(es8156, false);
416
417 return 0;
418 }
419 EXPORT_SYMBOL(es8156_headset_detect);
420

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2021-12-10 18:35    [W:0.035 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site