Messages in this thread | | | Subject | Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs | From | Bart Van Assche <> | Date | Fri, 10 Dec 2021 09:29:41 -0800 |
| |
On 12/9/21 10:42 PM, Greg Kroah-Hartman wrote: > A single hex value makes sense to me.
Hi Greg,
I'm not enthusiast about this approach because: (a) A single hex value can be confused with a number. Reporting a bitfield in hex format is not sufficient to prevent confusion with a number. (b) No other block layer sysfs attribute follows this encoding scheme. (c) This encoding enforces the restriction that data unit sizes are a power of two. Is there anything fundamental in encryption that restricts data unit sizes to a power of two? I don't know the answer myself.
Thanks,
Bart.
| |