lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR)
    On Tue, Dec 07, 2021 at 10:08:16PM +0100, Jonathan Neuschäfer wrote:
    > A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will
    > be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and
    > WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and
    > version information.
    >
    > This patch adds a binding to describe this node.
    >
    > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
    >
    > ---
    > v2:
    > - Rename node in example to syscon@800000
    > - Add subnode to example
    >
    > v1:
    > - https://lore.kernel.org/lkml/20210602120329.2444672-2-j.neuschaefer@gmx.net/
    > ---
    > .../bindings/arm/npcm/nuvoton,gcr.yaml | 45 +++++++++++++++++++
    > 1 file changed, 45 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml b/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml
    > new file mode 100644
    > index 0000000000000..62020d7ac305b
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/arm/npcm/nuvoton,gcr.yaml
    > @@ -0,0 +1,45 @@
    > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/arm/npcm/nuvoton,gcr.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Global Control Registers block in Nuvoton SoCs
    > +
    > +maintainers:
    > + - Jonathan Neuschäfer <j.neuschaefer@gmx.net>
    > +
    > +description: |

    Don't need '|' if no formatting.

    > + The Global Control Registers (GCR) are a block of registers in Nuvoton SoCs
    > + that expose misc functionality such as chip model and version information or
    > + pinmux settings.
    > +
    > +properties:
    > + compatible:
    > + items:
    > + - enum:
    > + - nuvoton,wpcm450-gcr
    > + - nuvoton,npcm750-gcr
    > + - const: syscon
    > + - const: simple-mfd

    blank line

    > + reg: true

    Need to define how many entries:

    maxItems: 1


    > +
    > +required:
    > + - compatible
    > + - reg
    > +
    > +additionalProperties: false

    Ideally, you should define the child node names, but you can do this:

    additionalProperties:
    type: object

    which means anything undefined must be a node.

    > +
    > +examples:
    > + - |
    > + gcr: syscon@800000 {
    > + compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd";
    > + reg = <0x800000 0x1000>;
    > +
    > + uart-mux-controller {
    > + compatible = "mmio-mux";
    > + #mux-control-cells = <1>;
    > + mux-reg-masks = <0x38 0x07>;
    > + idle-states = <2>;
    > + };
    > + };
    > --
    > 2.30.2
    >
    >

    \
     
     \ /
      Last update: 2021-12-10 15:55    [W:4.186 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site