Messages in this thread | | | From | Yasushi SHOJI <> | Date | Fri, 10 Dec 2021 17:57:35 +0900 | Subject | Re: [PATCH v5 3/5] can: do not copy the payload of RTR frames |
| |
Hi Vincent,
On Tue, Dec 7, 2021 at 9:16 PM Vincent Mailhol <mailhol.vincent@wanadoo.fr> wrote: > > The actual payload length of the CAN Remote Transmission Request (RTR) > frames is always 0, i.e. nothing is transmitted on the wire. However, > those RTR frames still use the DLC to indicate the length of the > requested frame. > > For this reason, it is incorrect to copy the payload of RTR frames > (the payload buffer would only contain garbage data). This patch > encapsulates the payload copy in a check toward the RTR flag. > > CC: Yasushi SHOJI <yashi@spacecubics.com> > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
It works and LGTM.
Tested-by: Yasushi SHOJI <yashi@spacecubics.com> -- yashi
| |