lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [fget] 054aa8d439: will-it-scale.per_thread_ops -5.7% regression
On Fri, Dec 10, 2021 at 3:30 PM Jann Horn <jannh@google.com> wrote:
>
> One nit: The original implementation is using rcu_dereference_raw()
> because it can run in different contexts, but here plain
> rcu_dereference() would probably be more appropriate?

Well, I actually did that somewhat on purpose.

The RCU locking is right there, so doing the checking seems pointless.

That's particularly true since the whole point of the patch was "this
is truly critical, let's rewrite it to generate basically perfect
code"..

Linus

\
 
 \ /
  Last update: 2021-12-11 02:02    [W:0.091 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site