Messages in this thread | | | Date | Wed, 1 Dec 2021 18:46:32 +0200 | Subject | Re: [PATCH 2/2] interconnect: qcom: Add SM8450 interconnect provider driver | From | Georgi Djakov <> |
| |
Hi Vinod,
Thanks for working on this!
On 1.12.21 9:25, Vinod Koul wrote: > Add driver for the Qualcomm interconnect buses found in SM8450 based > platforms. The topology consists of several NoCs that are controlled by > a remote processor that collects the aggregated bandwidth for each > master-slave pairs. > > This is based on the downstream driver by > Vivek Aknurwar <viveka@codeaurora.org>
Maybe CC him too.
> Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > drivers/interconnect/qcom/Kconfig | 9 + > drivers/interconnect/qcom/Makefile | 2 + > drivers/interconnect/qcom/sm8450.c | 1988 ++++++++++++++++++++++++++++ > drivers/interconnect/qcom/sm8450.h | 169 +++ > 4 files changed, 2168 insertions(+) > create mode 100644 drivers/interconnect/qcom/sm8450.c > create mode 100644 drivers/interconnect/qcom/sm8450.h > [..] > +static struct platform_driver qnoc_driver = { > + .probe = qnoc_probe, > + .remove = qnoc_remove, > + .driver = { > + .name = "qnoc-sm8450", > + .of_match_table = qnoc_of_match, > + .sync_state = icc_sync_state,
We should set this callback only after we enable the client drivers to request bandwidth. Otherwise some path might get disabled because of no users. I would suggest to add sync_state after we describe the paths in DT.
Thanks, Georgi
| |