Messages in this thread | | | Date | Wed, 1 Dec 2021 10:20:05 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing/histograms: String compares should not care about signed values |
| |
On Wed, 1 Dec 2021 11:21:00 +0900 Masami Hiramatsu <mhiramat@kernel.org> wrote:
> On Tue, 30 Nov 2021 12:37:36 -0500 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > From 95f7262b44dc54fed8007cc3db8b39cbd16999c6 Mon Sep 17 00:00:00 2001 > > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> > > Date: Tue, 30 Nov 2021 12:31:23 -0500 > > Subject: [PATCH] tracing/histograms: String compares should not care about > > signed values > > > > When comparing two strings for the "onmatch" histogram trigger, fields > > that are strings use string comparisons, which do not care about being > > signed or not. > > > > Do not fail to match two string fields if one is unsigned char array and > > the other is a signed char array. > > > > Link: https://lore.kernel.org/all/20211129123043.5cfd687a@gandalf.local.home/ > > Looks good to me. > > Review-by: Masami Hiramatsu <mhiramatsu@kernel.org> > >
Thanks Masami. I'll add your reviewed-by before posting to Linus.
-- Steve
| |