lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cgroup: Trace event cgroup id fields should be u64
Date
I'll break it up into two patches if you prefer, one that makes the stylistic change and then
another that makes the u64 change.

> On Dec 1, 2021, at 7:54 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 01, 2021 at 07:40:43AM -0700, William Kucharski wrote:
>> Various trace event fields that store cgroup IDs were declared
>> as ints, but cgroup_id(() returns a u64 and the conversion was
>> not intended.
>>
>> Also remove extraneous spaces in fields that are no longer proper C style.
>
> Shouldn't this be 2 different patches? When writing "also" that's a
> huge hint that the patch should be split up.
>
> So one for the bugfix, and one for the coding style change?
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2021-12-01 16:18    [W:0.085 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site