Messages in this thread | | | Date | Wed, 1 Dec 2021 14:54:42 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH v2 2/4] binder: avoid potential data leakage when copying txn |
| |
On Tue, Nov 30, 2021 at 10:51:50AM -0800, Todd Kjos wrote: > Transactions are copied from the sender to the target > first and objects like BINDER_TYPE_PTR and BINDER_TYPE_FDA > are then fixed up. This means there is a short period where > the sender's version of these objects are visible to the > target prior to the fixups. > > Instead of copying all of the data first, copy data only > after any needed fixups have been applied. > > Fixes: 457b9a6f09f0 ("Staging: android: add binder driver") > Reviewed-by: Martijn Coenen <maco@android.com> > Signed-off-by: Todd Kjos <tkjos@google.com> > ---
Looks good. Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
| |