lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs
    From
    Date
    On 11/30/21 8:40 AM, Eric Biggers wrote:
    > On Tue, Nov 30, 2021 at 07:49:54AM +0100, Hannes Reinecke wrote:
    >>> - "modes" is a sub-subdirectory, since there may be multiple supported
    >>> crypto modes, and sysfs is supposed to have one value per file.
    >>>
    >> Why do you have a sub-directory here?
    >> From what I can see, that subdirectory just contains the supported modes, so
    >> wouldn't it be easier to create individual files like 'mode_<modename>'
    >> instead of a subdirectory?
    >
    > It is a group of attributes, so it makes sense to group them together rather
    > than put them all in the parent directory alongside other attributes. It also
    > allows the use of proper names like "AES-256-XTS" rather than weird names like
    > "mode_AES-256-XTS" or "mode_aes_256_xts".
    >
    Right.

    Reviewed-by: Hannes Reinecke <hare@suse.de>

    Cheers,

    Hannes
    --
    Dr. Hannes Reinecke Kernel Storage Architect
    hare@suse.de +49 911 74053 688
    SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
    HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

    \
     
     \ /
      Last update: 2021-12-01 07:46    [W:5.590 / U:1.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site