lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] ceph: conversion to new fscache API
From
Date
On Mon, 2021-11-29 at 16:46 +0000, David Howells wrote:
> Jeff Layton <jlayton@kernel.org> wrote:
>
> > +void ceph_fscache_unregister_inode_cookie(struct ceph_inode_info* ci)
> > {
> > - return fscache_register_netfs(&ceph_cache_netfs);
> > + struct fscache_cookie* cookie = xchg(&ci->fscache, NULL);
> > +
> > + fscache_relinquish_cookie(cookie, false);
> > }
>
> xchg() should be excessive there. This is only called from
> ceph_evict_inode(). Also, if you're going to reset the pointer, it might be
> worth poisoning it rather than nulling it.
>

Ok, makes sense. I'll make that change soon.
--
Jeff Layton <jlayton@kernel.org>

\
 
 \ /
  Last update: 2021-12-01 12:32    [W:0.072 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site