lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] block: cancel all throttled bios in del_gendisk()
From
Date
在 2021/12/01 0:26, Tejun Heo 写道:
> Hello,
>
> On Tue, Nov 30, 2021 at 09:17:30AM +0800, Yu Kuai wrote:
>> +void blk_throtl_cancel_bios(struct request_queue *q)
>> +{
>> + struct throtl_data *td = q->td;
>> + struct blkcg_gq *blkg;
>> + struct cgroup_subsys_state *pos_css;
>> + struct bio *bio;
>> + int rw;
>> +
>> + rcu_read_lock();
>
> So, all of the draining is being performed without holding the q lock, which
> *might* be okay given that we're in the del_gendisk path but is likely risky
> - ie. there can still be timers or whatever racing against it.

I'll hold queue_lock to draining bios in next iteration,

Thanks,
Kuai
>
> Thanks.
>

\
 
 \ /
  Last update: 2021-12-01 10:26    [W:0.048 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site