Messages in this thread | | | Subject | Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy nodes from common dtsi | From | Sandeep Maheswaram <> | Date | Wed, 1 Dec 2021 10:29:07 +0530 |
| |
On 11/29/2021 11:32 PM, Matthias Kaehlcke wrote: > On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote: >> Remove USB2 controller and phy nodes from common dtsi file as it is >> required only for SKU1 board. >> >> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > A series shouldn't break things if it is only applied partially (in order). In > this case the USB2 controller wouldn't work on the SKU1 board if only this patch > is applied. It should be squashed with patch 2 of this series ("arm64: qcom: > sc7280: Add USB2 controller and phy nodes for SKU1 board"). > > Also doing the move in a single patch instead of two separate patches for remove > and add makes it easier to review the latter part, since it's evident from the > patch itself that it's just a move. Ok. Will do in next version.
| |