Messages in this thread | | | Date | Wed, 1 Dec 2021 11:41:08 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] media: meson: vdec: Fix a NULL pointer dereference in amvdec_add_ts() |
| |
On Wed, Dec 01, 2021 at 12:12:23AM +0800, Zhou Qingyang wrote: > diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.c b/drivers/staging/media/meson/vdec/vdec_helpers.c > index b9125c295d1d..41297c2f8f9a 100644 > --- a/drivers/staging/media/meson/vdec/vdec_helpers.c > +++ b/drivers/staging/media/meson/vdec/vdec_helpers.c > @@ -234,6 +234,11 @@ void amvdec_add_ts(struct amvdec_session *sess, u64 ts, > unsigned long flags; > > new_ts = kzalloc(sizeof(*new_ts), GFP_KERNEL); > + if (!new_ts) { > + dev_err(sess->core->dev_dec, > + "No enough memory in %s\n", __func__); > + return;
Please run checkpatch.pl on your patches. The dev_err() message should be deleted because kzalloc() already has a better message built in.
WARNING: Possible unnecessary 'out of memory' message #50: FILE: drivers/staging/media/meson/vdec/vdec_helpers.c:238: + if (!new_ts) { + dev_err(sess->core->dev_dec,
regards, dan carpenter
| |