Messages in this thread | | | Date | Wed, 1 Dec 2021 19:26:43 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls |
| |
On Thu, 2 Dec 2021 10:06:24 +0800 Bixuan Cui <cuibixuan@linux.alibaba.com> wrote:
> Delete the WARN_ON() and return NULL directly for oversized parameter > in kvmalloc() calls. > Also add unlikely(). > > Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls") > Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com> > --- > There are a lot of oversize warnings and patches about kvmalloc() calls > recently. Maybe these warnings are not very necessary.
Or maybe they are. Please let's take a look at these warnings, one at a time. If a large number of them are bogus then sure, let's disable the runtime test. But perhaps it's the case that calling code has genuine issues and should be repaired.
| |