Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 2 Dec 2021 02:47:02 +0100 | Subject | Re: [PATCH v5 12/13] gpio: Add support for Airoha EN7523 GPIO controller |
| |
Hi Felix!
Thanks for your patch!
On Mon, Nov 29, 2021 at 4:54 PM Felix Fietkau <nbd@nbd.name> wrote:
> From: John Crispin <john@phrozen.org> > > Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32 > GPIOs. Each instance in DT is for an single bank. > > Signed-off-by: John Crispin <john@phrozen.org> > Signed-off-by: Felix Fietkau <nbd@nbd.name>
(...) > +config GPIO_EN7523 > + tristate "Airoha GPIO support" > + depends on ARCH_AIROHA > + default ARCH_AIROHA > + select GPIO_GENERIC
Yes that looks applicable, but why isn't it used?
The few 32-bit registers look like an ideal candidate for using the generic GPIO. Check similar drivers such as drivers/gpio/gpio-ftgpio010.c and how it uses bgpio_init() and the nice doc for bgpio_init() in drivers/gpio/gpio-mmio.c.
If it's not working already with generic GPIO I do not think it would be far fetched to fix it.
Yours, Linus Walleij
| |