lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties
On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "snps,block-size" and "snps,priority" properties should be grouped
> using angle brackets.

For these, the tools should allow either way. Where are you seeing an
error?

I tried to rationalize which way should be 'correct' and gave up. I
think bracketing only makes sense for matrix and phandle+arg cases.

>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 79e241498e2532ce..90d9274e5464e396 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -120,7 +120,7 @@ examples:
> dma-channels = <4>;
> snps,dma-masters = <2>;
> snps,data-width = <3>;
> - snps,block-size = <4096 4096 4096 4096>;
> - snps,priority = <0 1 2 3>;
> + snps,block-size = <4096>, <4096>, <4096>, <4096>;
> + snps,priority = <0>, <1>, <2>, <3>;
> snps,axi-max-burst-len = <16>;
> };
> --
> 2.25.1
>
>

\
 
 \ /
  Last update: 2021-12-01 23:44    [W:0.054 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site