lkml.org 
[lkml]   [2021]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 40/82] ASoC: es8316: Use IRQF_NO_AUTOEN when requesting the IRQ
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit 1cf2aa665901054b140eb71748661ceae99b6b5a ]

    Use the new IRQF_NO_AUTOEN flag when requesting the IRQ, rather then
    disabling it immediately after requesting it.

    This fixes a possible race where the IRQ might trigger between requesting
    and disabling it; and this also leads to a small code cleanup.

    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20211003132255.31743-1-hdegoede@redhat.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/es8316.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
    index 067757d1d70a3..5fb02635c1406 100644
    --- a/sound/soc/codecs/es8316.c
    +++ b/sound/soc/codecs/es8316.c
    @@ -811,12 +811,9 @@ static int es8316_i2c_probe(struct i2c_client *i2c_client,
    mutex_init(&es8316->lock);

    ret = devm_request_threaded_irq(dev, es8316->irq, NULL, es8316_irq,
    - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
    + IRQF_TRIGGER_HIGH | IRQF_ONESHOT | IRQF_NO_AUTOEN,
    "es8316", es8316);
    - if (ret == 0) {
    - /* Gets re-enabled by es8316_set_jack() */
    - disable_irq(es8316->irq);
    - } else {
    + if (ret) {
    dev_warn(dev, "Failed to get IRQ %d: %d\n", es8316->irq, ret);
    es8316->irq = -ENXIO;
    }
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-09 23:20    [W:4.067 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site