Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 9 Nov 2021 08:57:27 +0100 | Subject | Re: [PATCH] [PATCH v2] ARM: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE |
| |
On Tue, Nov 9, 2021 at 7:03 AM Julian Braha <julianbraha@gmail.com> wrote: > > When ARM is enabled, and BITREVERSE is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for HAVE_ARCH_BITREVERSE > Depends on [n]: BITREVERSE [=n] > Selected by [y]: > - ARM [=y] && (CPU_32v7M [=n] || CPU_32v7 [=y]) && !CPU_32v6 [=n] > > This is because ARM selects HAVE_ARCH_BITREVERSE > without selecting BITREVERSE, despite > HAVE_ARCH_BITREVERSE depending on BITREVERSE. > > This unmet dependency bug was found by Kismet, > a static analysis tool for Kconfig.
Looks good to me, please add it to the patch tracker[1].
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Please advise if this > is not the appropriate solution. > > v2: > Changed this fix to remove the dependency on BITREVERSE from > HAVE_ARCH_BITREVERSE, since it isn't actually necessary.
This bit should go below the --- line. You can also add a Link: tag pointing to v1 [2].
Arnd
[1] https://www.armlinux.org.uk/developer/patches/info.php [2] https://lore.kernel.org/linux-arm-kernel/20211029203110.8343-1-julianbraha@gmail.com/
| |